commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stephan Köninger (JIRA) <j...@apache.org>
Subject [jira] [Updated] (IMAGING-149) Colors should check whether color components are in allowed ranges
Date Thu, 08 Jan 2015 19:57:34 GMT

     [ https://issues.apache.org/jira/browse/IMAGING-149?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Stephan Köninger updated IMAGING-149:
-------------------------------------
    Attachment: IMAGING-149_partial_001.patch

Hi, 

I am not quite sure how to implement the behavior of this issue. Hence I have created a patch
which just contains changes for ColorHsv class. Do you think it is a good idea to throw IllegalArgumentExceptions
when the desired color component is out of range? In addition: How should one test it? I used
the @Test(expected = IllegalArgumentException.class) Feature of JUnit. Is it sufficient? 

Sincerely,
Stephan

> Colors should check whether color components are in allowed ranges
> ------------------------------------------------------------------
>
>                 Key: IMAGING-149
>                 URL: https://issues.apache.org/jira/browse/IMAGING-149
>             Project: Commons Imaging
>          Issue Type: Improvement
>          Components: imaging.color.*
>            Reporter: Benedikt Ritter
>             Fix For: Patch Needed
>
>         Attachments: IMAGING-149_partial_001.patch
>
>
> Each color in the color package should check the parameters passed into the constructor
for validity regarding their color space.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message