commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benedikt Ritter (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (IMAGING-147) Add color constants
Date Tue, 06 Jan 2015 20:57:35 GMT

    [ https://issues.apache.org/jira/browse/IMAGING-147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14266749#comment-14266749
] 

Benedikt Ritter commented on IMAGING-147:
-----------------------------------------

Hello Stephan,

very nice patch and thanks for the explanation ;-) I've found some more copy and paste errors
in the JavaDocs and have corrected them. The convertTo method is a very good idea. Would be
create if every color could be converted to every other. I'd like to get rid of the ColorConversions
class or at least make it package private. Feel free to create a new ticket for this change
an attach a patch + junit test.

{code}
$ svn ci -m "IMAGING-147: Add color constants. This also closes #3 from github. Thanks to
Stephan Koeninger."
Sending        src/changes/changes.xml
Sending        src/main/java/org/apache/commons/imaging/color/ColorCieLab.java
Sending        src/main/java/org/apache/commons/imaging/color/ColorCieLch.java
Sending        src/main/java/org/apache/commons/imaging/color/ColorCieLuv.java
Sending        src/main/java/org/apache/commons/imaging/color/ColorCmy.java
Sending        src/main/java/org/apache/commons/imaging/color/ColorCmyk.java
Sending        src/main/java/org/apache/commons/imaging/color/ColorHsl.java
Sending        src/main/java/org/apache/commons/imaging/color/ColorHsv.java
Sending        src/main/java/org/apache/commons/imaging/color/ColorHunterLab.java
Sending        src/main/java/org/apache/commons/imaging/color/ColorXyz.java
Transmitting file data ..........
Committed revision 1649947.
{code}

Thank you!

> Add color constants
> -------------------
>
>                 Key: IMAGING-147
>                 URL: https://issues.apache.org/jira/browse/IMAGING-147
>             Project: Commons Imaging
>          Issue Type: Improvement
>          Components: imaging.color.*
>            Reporter: Benedikt Ritter
>              Labels: github
>             Fix For: Review Patch
>
>         Attachments: IMAGING-147_001.patch, IMAGING-147_002.patch
>
>
> The Color classes should provide constants for useful colors like black, white and maybe
their base colors. For example ColorCmyk could provide Constants for black, white, cyan, magenta
and yellow ColorCmyk objects.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message