commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benedikt Ritter (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (IMAGING-147) Color constants
Date Fri, 02 Jan 2015 21:35:34 GMT

    [ https://issues.apache.org/jira/browse/IMAGING-147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14263250#comment-14263250
] 

Benedikt Ritter commented on IMAGING-147:
-----------------------------------------

I'm currently a bit unsure about the various constants that use really odd values like for
example ColorHunterLab RED = new ColorHunterLab(46.109, 78.962, 29.794); This feels to random
to me.

Further more it doesn't feel sound that all but the cmy color classes define red, green and
blue. cmy should also define these as mix colors.

Regarding documentation it would probably be good to add some explanatory sentences like 

{code}
A constant for the color red. Color components are:
<pre>
Cyan: ...
Magenta: ...
...
<pre>
{code}

> Color constants
> ---------------
>
>                 Key: IMAGING-147
>                 URL: https://issues.apache.org/jira/browse/IMAGING-147
>             Project: Commons Imaging
>          Issue Type: Improvement
>          Components: imaging.color.*
>            Reporter: Benedikt Ritter
>              Labels: github
>             Fix For: Review Patch
>
>
> The Color classes should provide constants for useful colors like black, white and maybe
their base colors. For example ColorCmyk could provide Constants for black, white, cyan, magenta
and yellow ColorCmyk objects.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message