commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benedikt Ritter (JIRA)" <>
Subject [jira] [Updated] (VALIDATOR-336) CUSIPCheckDigit thinks invalid CUSIP is valid
Date Thu, 01 Jan 2015 15:47:13 GMT


Benedikt Ritter updated VALIDATOR-336:
          Component/s: Routines
    Affects Version/s: 1.4.0 Release
        Fix Version/s: 1.4.1

> CUSIPCheckDigit thinks invalid CUSIP is valid
> ---------------------------------------------
>                 Key: VALIDATOR-336
>                 URL:
>             Project: Commons Validator
>          Issue Type: Bug
>          Components: Routines
>    Affects Versions: 1.4.0 Release
>            Reporter: Josh Meyer
>            Assignee: Benedikt Ritter
>             Fix For: 1.4.1
>         Attachments:,,,
VALIDATOR-336.patch, cusip.patch
> When testing if a specific CUSIP is valid using org.apache.commons.validator.routines.checkdigit.CUSIPCheckDigit.CUSIP_CHECK_DIGIT.isValid,
a call to this returns true when it should return false. A specific example is with the following
invalid CUSIP: DUS0421CW.
> What seems to be happening is when toInt is called on W it turns it to an int value and
then sends it to weightedValue. This is fine for the first 8 characters of a CUSIP, but not
the check digit. The expected result should be to return false because the check digit is
a letter (on a CUSIP a check digit must be 0-9). 
> With the current implementation, I believe each CUSIP can have up to 4 valid check digits.
> A test is attached.

This message was sent by Atlassian JIRA

View raw message