commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sebb (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (NET-525) Added missing set methods on NTP class and interface
Date Sun, 18 Jan 2015 22:46:35 GMT

    [ https://issues.apache.org/jira/browse/NET-525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14281991#comment-14281991
] 

Sebb commented on NET-525:
--------------------------

Changes to interface broke compatibility.

URL: http://svn.apache.org/r1652867
Log:
NET-525 Added missing set methods on NTP class and interface
Restore compatibility

Added:
    commons/proper/net/trunk/src/main/java/org/apache/commons/net/ntp/NtpV3Packetbis.java
Modified:
    commons/proper/net/trunk/src/main/java/examples/ntp/SimpleNTPServer.java
    commons/proper/net/trunk/src/main/java/org/apache/commons/net/ntp/NtpV3Impl.java
    commons/proper/net/trunk/src/main/java/org/apache/commons/net/ntp/NtpV3Packet.java
    commons/proper/net/trunk/src/test/java/org/apache/commons/net/ntp/TestNtpPacket.java
    commons/proper/net/trunk/src/test/java/org/apache/commons/net/ntp/TestTimeInfo.java


> Added missing set methods on NTP class and interface
> ----------------------------------------------------
>
>                 Key: NET-525
>                 URL: https://issues.apache.org/jira/browse/NET-525
>             Project: Commons Net
>          Issue Type: Improvement
>    Affects Versions: 3.3
>            Reporter: jason mathews
>              Labels: ntp
>             Fix For: 3.4
>
>         Attachments: diff.patch.txt
>
>
> I was the original contributor of the NTP implementation and have recently cleaned the
source and submitting the relevant changes.
> Here is the summary of changes:
> src/main/java/org/apache/commons/net/ntp/TimeInfo.java
> -Added missing equals() and hashCode() methods
> -Added new method: getAddress() 
> src/main/java/org/apache/commons/net/ntp/NtpV3Packet.java
> -Added missing methods: setPrecision(), setRootDelay(), and setRootDispersion()
> src/main/java/org/apache/commons/net/ntp/NtpV3Impl.java
> -Added missing equals() and hashCode() methods
> -Added missing set methods: setRootDelay(), setRootDispersion(), 
> -Added validation check to setDatagramPacket()
> Added additional tests:
> -src/test/java/org/apache/commons/net/ntp/TestNtpPacket.java
> -src/test/java/org/apache/commons/net/ntp/TestTimeInfo.java
> See attached patch.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message