commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sebb (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (VALIDATOR-290) Create new url validation using rfc3986 and IDN
Date Mon, 05 Jan 2015 14:52:35 GMT

    [ https://issues.apache.org/jira/browse/VALIDATOR-290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14264043#comment-14264043
] 

Sebb edited comment on VALIDATOR-290 at 1/5/15 2:51 PM:
--------------------------------------------------------

Thanks for the patches.
Have already fixed DomainValidator TOP_LABEL_REGEX Regex.
BTW the patch RE is not quite correct, as it allows a trailing "-" which is not valid
Decided not to have separate list for internationalised TLDs.

Added test case, with one change: Syria is "xn\-\-ogbpf8fl" not "xn\-\-mgbtf8fl"

URL: http://svn.apache.org/r1649428
Log:
VALIDATOR-290 - Create new url validation using rfc3986 and IDN - added new test

Modified:
    commons/proper/validator/trunk/RELEASE-NOTES.txt
    commons/proper/validator/trunk/src/changes/changes.xml
    commons/proper/validator/trunk/src/test/java/org/apache/commons/validator/routines/UrlValidatorTest.java


was (Author: sebb@apache.org):
Thanks for the patches.
Have already fixed DomainValidator TOP_LABEL_REGEX Regex.
BTW the patch RE is not quite correct, as it allows a trailing "-" which is not valid
Decided not to have separate list for internationalised TLDs.

Added test case, with one change: Syria is "xn--ogbpf8fl" not "xn--mgbtf8fl"

URL: http://svn.apache.org/r1649428
Log:
VALIDATOR-290 - Create new url validation using rfc3986 and IDN - added new test

Modified:
    commons/proper/validator/trunk/RELEASE-NOTES.txt
    commons/proper/validator/trunk/src/changes/changes.xml
    commons/proper/validator/trunk/src/test/java/org/apache/commons/validator/routines/UrlValidatorTest.java

> Create new url validation using rfc3986 and IDN
> -----------------------------------------------
>
>                 Key: VALIDATOR-290
>                 URL: https://issues.apache.org/jira/browse/VALIDATOR-290
>             Project: Commons Validator
>          Issue Type: New Feature
>          Components: Routines
>    Affects Versions: 1.3.1 Release, 1.4.0 Release
>            Reporter: Alexander Rytov
>             Fix For: 1.4.1
>
>         Attachments: VALIDATOR-290-test.patch, VALIDATOR-290.patch
>
>
> UrlValidation at the moment use old rfc2396 and doesn't check IDN (through punycode or
something)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message