Return-Path: X-Original-To: apmail-commons-issues-archive@minotaur.apache.org Delivered-To: apmail-commons-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 24934106B0 for ; Wed, 10 Dec 2014 01:59:13 +0000 (UTC) Received: (qmail 54255 invoked by uid 500); 10 Dec 2014 01:59:13 -0000 Delivered-To: apmail-commons-issues-archive@commons.apache.org Received: (qmail 54156 invoked by uid 500); 10 Dec 2014 01:59:12 -0000 Mailing-List: contact issues-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: issues@commons.apache.org Delivered-To: mailing list issues@commons.apache.org Received: (qmail 54144 invoked by uid 99); 10 Dec 2014 01:59:12 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 10 Dec 2014 01:59:12 +0000 Date: Wed, 10 Dec 2014 01:59:12 +0000 (UTC) From: "Sebb (JIRA)" To: issues@commons.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Resolved] (NET-563) MLSxEntryParser needs test cases; parsing is too lax MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/NET-563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sebb resolved NET-563. ---------------------- Resolution: Fixed Fix Version/s: 3.4 URL: http://svn.apache.org/r1644305 Log: NET-563 MLSxEntryParser needs test cases; parsing is too lax Added: commons/proper/net/trunk/src/test/java/org/apache/commons/net/ftp/parser/MLSxEntryParserTest.java Modified: commons/proper/net/trunk/src/changes/changes.xml commons/proper/net/trunk/src/main/java/org/apache/commons/net/ftp/parser/MLSxEntryParser.java > MLSxEntryParser needs test cases; parsing is too lax > ---------------------------------------------------- > > Key: NET-563 > URL: https://issues.apache.org/jira/browse/NET-563 > Project: Commons Net > Issue Type: Bug > Reporter: Sebb > Fix For: 3.4 > > > The MLSxEntryParser currently has no proper unit tests. > Also the parsing is too lax, for example at least one fact is required unless the entry starts with a space, but this is not detected. -- This message was sent by Atlassian JIRA (v6.3.4#6332)