commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben McCann (JIRA)" <>
Subject [jira] [Updated] (BCEL-186) Release 6.0
Date Tue, 30 Dec 2014 15:18:13 GMT


Ben McCann updated BCEL-186:
    Attachment: revert-ConstantUtf8-cache.diff

This patch removes the cache in ConstantUtf8. Konstantin Kolinko and Emmanuel Bourg investigated
and found it had a negative impact on performance. Also the feature isn't well implemented
due to the static state it introduces.

> Release 6.0
> -----------
>                 Key: BCEL-186
>                 URL:
>             Project: Commons BCEL
>          Issue Type: Task
>    Affects Versions: 6.0
>            Reporter: Ben McCann
>            Priority: Blocker
>         Attachments: revert-ConstantUtf8-cache.diff
> I'd love to see 6.0 released.
> Here was the last vote:
> Konstantin Kolinko reported some issues with caching that blocked the release:
> bq. I noted new methods that introduced caching into classfile.ConstantUtf8 class. BCEL_DONT_CACHE
should at least have static setter, or a static setter for a cache instance / a factory class.
RELEASE-NOTES.txt describes this change as [BCEL-163] Incorporate patch file from Findbugs
which does not say much about this change. Actually this change introduced caching for ConstantUtf8
and ObjectType instances.
> Emmanuel Bourg did some investigation and testing and reported back:
> bq. If nobody object I'll remove this cache, the impact on the performance is too important
to enable it by default, and the static state smells like a quick and dirty implementation.
This feature could return as a pluggable cache if someone wants to provide a patch.
> garydgregory suggested adding a flush method to clear the cache in ObjectType

This message was sent by Atlassian JIRA

View raw message