commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Emmanuel Bourg (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BCEL-183) Implement Java 7 field/method name validation rules
Date Wed, 17 Dec 2014 12:48:14 GMT

    [ https://issues.apache.org/jira/browse/BCEL-183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14249795#comment-14249795
] 

Emmanuel Bourg commented on BCEL-183:
-------------------------------------

Exact. I changed the {{validFieldName()}} method to:

{code}
    private static boolean validFieldName(int version, String name) {
        if (version >= MAJOR_1_7) {
            return validUnqualifiedName(name);
        } else {
            return validJavaIdentifier(name);
        }
    }
{code}

I haven't checked how the spec evolved for the method names yet.

> Implement Java 7 field/method name validation rules
> ---------------------------------------------------
>
>                 Key: BCEL-183
>                 URL: https://issues.apache.org/jira/browse/BCEL-183
>             Project: Commons BCEL
>          Issue Type: Improvement
>          Components: Verifier
>    Affects Versions: 5.2
>            Reporter: Jérôme Leroux
>             Fix For: 6.0
>
>         Attachments: BCEL-183-2.patch, BCEL-183-2.zip, BCEL-183-src.zip, BCEL-183.patch,
BCEL-183.zip
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> The JustIce bytecode verifier checks the validity of the field name and the variable
name considering the java langage specification. 
> This check is not specified by the bytecode verifier specification.
> This may lead to bytecode verification errors in pass2 on valid classfiles.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message