commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gilles (JIRA)" <>
Subject [jira] [Commented] (MATH-1179) kolmogorovSmirnovTest poor performance in monteCarloP method
Date Mon, 15 Dec 2014 13:06:13 GMT


Gilles commented on MATH-1179:

bq. All of your conditions are based on the product of the vector lengths in the following
way: x.length * y.length. However, if you have long vectors, such as 50,000 each (as in my
case) the product is out of integer bounds

That would be a bug. Thanks for spotting it.
Could you open a specific issue for it?

> kolmogorovSmirnovTest poor performance in monteCarloP method
> ------------------------------------------------------------
>                 Key: MATH-1179
>                 URL:
>             Project: Commons Math
>          Issue Type: Bug
>            Reporter: Gilad
>             Fix For: 4.0
>         Attachments: KSTest-JavaAndR.txt, KSTestSnippet.txt
> I'm using the kolmogovSmirnovTest method to calculate pvalues.
> However, when i try running the test on two double[] of sizes 5 and 45 the results take
over 10 seconds to calculate.
> This seems very long, whereas in R it takes a few miliseconds for the same calculation.
> I'd be very happy to hear any comment you may have on the subject.
>    Gilad

This message was sent by Atlassian JIRA

View raw message