commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "haiyang li (JIRA)" <j...@apache.org>
Subject [jira] [Created] (LANG-1073) Read wrong component type of array in add in ArrayUtils
Date Wed, 03 Dec 2014 00:02:13 GMT
haiyang li created LANG-1073:
--------------------------------

             Summary: Read wrong component type of array in add in ArrayUtils
                 Key: LANG-1073
                 URL: https://issues.apache.org/jira/browse/LANG-1073
             Project: Commons Lang
          Issue Type: Bug
          Components: lang.*
    Affects Versions: 3.3.2
            Reporter: haiyang li
            Priority: Minor
             Fix For: Discussion


{code:title=org.apache.commons.lang3.ArrayUtils.java|borderStyle=solid}
    public static <T> T[] add(final T[] array, final T element) {
        Class<?> type;
        if (array != null){
            type = array.getClass();
        } else if (element != null) {
            type = element.getClass();
        } else {
            throw new IllegalArgumentException("Arguments cannot both be null");
        }
        .......
    }
{code}

I think it should be:

{code:title=org.apache.commons.lang3.ArrayUtils.java|borderStyle=solid}
    public static <T> T[] add(final T[] array, final T element) {
        Class<?> type;
        if (array != null){
            type = array.getClass().getComponentType();
        } else if (element != null) {
            type = element.getClass();
        } else {
            throw new IllegalArgumentException("Arguments cannot both be null");
        }
        .......
    }
{code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message