commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sebb (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (LANG-1072) Duplicated "0x" check in createBigInteger in NumberUtils
Date Wed, 03 Dec 2014 01:41:13 GMT

     [ https://issues.apache.org/jira/browse/LANG-1072?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Sebb resolved LANG-1072.
------------------------
       Resolution: Fixed
    Fix Version/s:     (was: Discussion)
                   3.4

Thanks!

Fixed in r1643038

http://svn.apache.org/viewvc?view=revision&revision=r1643038

> Duplicated "0x" check in createBigInteger in NumberUtils
> --------------------------------------------------------
>
>                 Key: LANG-1072
>                 URL: https://issues.apache.org/jira/browse/LANG-1072
>             Project: Commons Lang
>          Issue Type: Bug
>          Components: lang.math.*
>    Affects Versions: 3.3.2
>            Reporter: haiyang li
>            Priority: Minor
>             Fix For: 3.4
>
>
> I think there is typo in below line:
> {code:title= org.apache.commons.lang3.math.NumberUtils.java|borderStyle=solid}
>  if (str.startsWith("0x", pos) || str.startsWith("0x", pos)) { // hex
>             radix = 16;
>             pos += 2;
> }
> {code}
> The second "0x" should be "0X"
> {code:title= org.apache.commons.lang3.math.NumberUtils.java|borderStyle=solid}
>  if (str.startsWith("0x", pos) || str.startsWith("0X", pos)) { // hex
>             radix = 16;
>             pos += 2;
> }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message