commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sebb (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (VALIDATOR-341) Make TLD list configurable
Date Wed, 31 Dec 2014 16:26:13 GMT

    [ https://issues.apache.org/jira/browse/VALIDATOR-341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14262279#comment-14262279
] 

Sebb commented on VALIDATOR-341:
--------------------------------

It seems a bit wasteful to have to parse the list each time when this can be done once just
prior to creating a release.
[Indeed the sort could be done beforehand as well, and the unit test could check it]

Also I'm thinking that the user should only have to provide a list of additional TLDs.
I don't think they are ever deleted.

The file search would need to be optional, I think, perhaps as a new static method.
It would otherwise be unnecessary overhead for everyone, even those who don't need/want it.

Might also be worth looking at whether it's worth serialising/de-serialising the data rather
than recreating it on startup.
For example, if an external file is found, update the table and serialise to disk.
If a serialised file is found, use that, else the external file.
Could compare dates to decide which to use; there's always the option of deleting the serialised
file.
But maybe that is taking things too far.

> Make TLD list configurable
> --------------------------
>
>                 Key: VALIDATOR-341
>                 URL: https://issues.apache.org/jira/browse/VALIDATOR-341
>             Project: Commons Validator
>          Issue Type: New Feature
>          Components: Framework
>            Reporter: Benedikt Ritter
>              Labels: TLD, domains, email
>
> Since the list of valid TLDs changes from time to time, it makes sense to let users configure
the list of valid TLDs.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message