commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sebb (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FILEUPLOAD-242) Should not catch and ignore Throwable
Date Wed, 03 Dec 2014 12:44:12 GMT

    [ https://issues.apache.org/jira/browse/FILEUPLOAD-242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14232955#comment-14232955
] 

Sebb commented on FILEUPLOAD-242:
---------------------------------

Followup:

URL: http://svn.apache.org/r1643019
Log:
[FILEUPLOAD-242] Do not silently swallow all Throwables.
Instead swallow only Exceptions

Modified:
    commons/proper/fileupload/trunk/src/main/java/org/apache/commons/fileupload/FileUploadBase.java


> Should not catch and ignore Throwable
> -------------------------------------
>
>                 Key: FILEUPLOAD-242
>                 URL: https://issues.apache.org/jira/browse/FILEUPLOAD-242
>             Project: Commons FileUpload
>          Issue Type: Bug
>            Reporter: Sebb
>             Fix For: 1.4
>
>
> Code should never catch & ignore all Throwables.
> For example, ThreadDeath may be caught, but must be rethrown.
> VirtualMachineError must also never be swallowed.
> See also
> https://issues.apache.org/bugzilla/show_bug.cgi?id=48644
> and
> org/apache/tomcat/util/ExceptionUtils#handleThrowable()
> https://svn.apache.org/repos/asf/tomcat/trunk/java/org/apache/tomcat/util/ExceptionUtils.java



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message