commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "James Sawle (JIRA)" <>
Subject [jira] [Commented] (LANG-701) StringUtils join with var args
Date Mon, 15 Dec 2014 07:47:13 GMT


James Sawle commented on LANG-701:

I will have a look at the null input value today or this evening and make any relevant change
and add suitable JavadocI am willing to go through the rest of the class (and any others I
touch) and migrate all to the new format.

The issue I have with the @Expected annotation, is that there is no regression testing for
the messages; which it is not uncommon to see people assert over in their code (I know not
good practice but people still do it). I am willing as part of this or another issue to migrate
the entire test class to this structure, and/or as lang4 do the rest of the codebase.

> StringUtils join with var args
> ------------------------------
>                 Key: LANG-701
>                 URL:
>             Project: Commons Lang
>          Issue Type: New Feature
>          Components: lang.*
>            Reporter: Gabriele Kahlout
>            Priority: Minor
>             Fix For: Review Patch
>         Attachments:
> {code:java}
> final String apple = "apple";
> final String banana = "banana";
> final String orange = "orange";
> final String expected = apple +  SPACE + banana + SPACE + orange;
> final String  actual = join(SPACE, apple, banana, orange);
> final int expLength = expected.length();
> final int actLength = actual.length();
> assertEquals(expLength, actLength);
> assertEquals(expected, actual);
> {code}
> I missed the functionality of joining strings with the space separator in one line. BTW,
why space ' ' not a constant field anywhere?

This message was sent by Atlassian JIRA

View raw message