commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benedikt Ritter (JIRA)" <>
Subject [jira] [Commented] (LANG-1070) confusing example in ArrayUtils.add()
Date Sun, 30 Nov 2014 18:38:12 GMT


Benedikt Ritter commented on LANG-1070:

The current behavior of {{add(T[], T)}} seems to be inconsistent with the various varargs
methods. For example calling {{addAll(boolean[], boolean...)}} with null will return null.
So maybe instead of changing the docs, we should let {{add(T[], T)}} simply return null for
null inputs. WDYT?

> confusing example in ArrayUtils.add()
> -------------------------------------
>                 Key: LANG-1070
>                 URL:
>             Project: Commons Lang
>          Issue Type: Improvement
>          Components: lang.*
>    Affects Versions: 3.3.2
>            Reporter: Paul Pogonyshev
>            Priority: Trivial
> Method documentation claims that
>     ArrayUtils.add(null, null)     = null
> However, this is not true since this parameter combination leads to an exception.
> Either remove this line from documentation, or rewrite it to explicitly mention the exception.
Maybe there are other related methods with similar problem in the docs.

This message was sent by Atlassian JIRA

View raw message