Mailing-List: contact issues-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: issues@commons.apache.org
Date: Sun, 26 Oct 2014 17:26:33 +0000 (UTC)
From: "Bernd Eckenfels (JIRA)" <jira@apache.org>
To: issues@commons.apache.org
Message-ID: <JIRA.12750615.1414342870000.340955.1414344393723@Atlassian.JIRA>
In-Reply-To: <JIRA.12750615.1414342870000@Atlassian.JIRA>
References: <JIRA.12750615.1414342870000@Atlassian.JIRA>
 <JIRA.12750615.1414342870864@arcas>
Subject: [jira] [Commented] (LANG-1058) StringUtils.uncapitalize performance
 improvement
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/LANG-1058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14184553#comment-14184553 ] 

Bernd Eckenfels commented on LANG-1058:
---------------------------------------

Do you mean the possible improvement of skipping one char operation, like:

{code}
    public static String uncapitalize(final String str) {
        int strLen;
        if (str == null || (strLen = str.length()) == 0) {
            return str;
        }

        final char firstChar = str.charAt(0);
        final char newChar = Character.toLowerCase(firstChar);
        if (firstChar == newChar) {
            // already uncapitalized
            return str;
        }

        return new StringBuilder(strLen)
            .append(newChar)
            .append(str.substring(1))
            .toString();
    }
{code}

(I dont think repacing Stringbuilder with ""+"" is a good thing here as we know the target string size and can optimize for it)

> StringUtils.uncapitalize performance improvement
> ------------------------------------------------
>
>                 Key: LANG-1058
>                 URL: https://issues.apache.org/jira/browse/LANG-1058
>             Project: Commons Lang
>          Issue Type: Improvement
>          Components: lang.*
>            Reporter: Leo Wang
>


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)