Mailing-List: contact issues-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: issues@commons.apache.org
Date: Mon, 6 Oct 2014 08:28:34 +0000 (UTC)
From: "Vladimir Konkov (JIRA)" <jira@apache.org>
To: issues@commons.apache.org
Message-ID: <JIRA.12746058.1412583494000.196400.1412584114231@Atlassian.JIRA>
In-Reply-To: <JIRA.12746058.1412583494000@Atlassian.JIRA>
References: <JIRA.12746058.1412583494000@Atlassian.JIRA>
 <JIRA.12746058.1412583494666@arcas>
Subject: [jira] [Updated] (DBCP-428) Unsuccessful Connection enlistment in
 XA Transaction ignored by TransactionContext
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/DBCP-428?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vladimir Konkov updated DBCP-428:
---------------------------------
    Attachment: DBCP-428.diff

I've attached simple patch for this issue. Unfortunately, with current test infrastructure provide test case is very time demand. Currently code path with connection enlistment is tested only by optimistic path. I will try create separate test suite for test XA interation.

> Unsuccessful Connection enlistment in XA Transaction ignored by TransactionContext
> ----------------------------------------------------------------------------------
>
>                 Key: DBCP-428
>                 URL: https://issues.apache.org/jira/browse/DBCP-428
>             Project: Commons Dbcp
>          Issue Type: Bug
>    Affects Versions: 1.4, 2.0.1
>         Environment: All
>            Reporter: Vladimir Konkov
>            Priority: Critical
>         Attachments: DBCP-428.diff
>
>
> When TransactionContext call 'enlistResource()' on Transaction it is ignored returned result. This hapens at least when XAResource throws XAException in enlistResource method. By contract XAException should not be propagated by 'enlistResource()' , instead 'false' is returned.
> As result:
> 1. ManagedConnection returned by pool is not enlisted in transaction (application think it does)
> 2. Transaction itself marked for rollback (because of XaException).
> 3. ManagedConnection returned by pool used by application without any errors until commit on transaction is called. Changes made in not enlisted connection may be commited on other use of native connection or rolled back depending on pool config.
> Issue is very dangerous especialy if changed made by application will be commited later but XA transaction in witch it made has bin rolled back.
> We are hit by this bug in production using MS SQL Server and PostgreSQL JDBC drivers.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)