Return-Path: X-Original-To: apmail-commons-issues-archive@minotaur.apache.org Delivered-To: apmail-commons-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 880E2172EC for ; Wed, 15 Oct 2014 01:48:37 +0000 (UTC) Received: (qmail 48222 invoked by uid 500); 15 Oct 2014 01:48:35 -0000 Delivered-To: apmail-commons-issues-archive@commons.apache.org Received: (qmail 48125 invoked by uid 500); 15 Oct 2014 01:48:35 -0000 Mailing-List: contact issues-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: issues@commons.apache.org Delivered-To: mailing list issues@commons.apache.org Received: (qmail 48113 invoked by uid 99); 15 Oct 2014 01:48:35 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 15 Oct 2014 01:48:35 +0000 Date: Wed, 15 Oct 2014 01:48:35 +0000 (UTC) From: "Maxim Degtyarev (JIRA)" To: issues@commons.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Comment Edited] (BCEL-180) Enable loading ConstantPool from a byte array MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/BCEL-180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14171864#comment-14171864 ] Maxim Degtyarev edited comment on BCEL-180 at 10/15/14 1:47 AM: ---------------------------------------------------------------- I disagree, passing class file format version to the constant pool constructor smells bad. At my point of view, such checks should not be responsibility of ConstantPool class but instead take place in ClassParser for ordinary class loading. Or, in case ClassParser not used, should be performed explicitly in code that use BCEL library. was (Author: maccimo): I disagree, passing class file format version to the constructor smells bad. At my point of view, such checks should not be responsibility of ConstantPool class but instead take place in ClassParser for ordinary class loading. Or, in case ClassParser not used, should be performed explicitly in code that use BCEL library. > Enable loading ConstantPool from a byte array > --------------------------------------------- > > Key: BCEL-180 > URL: https://issues.apache.org/jira/browse/BCEL-180 > Project: Commons BCEL > Issue Type: Improvement > Reporter: Maxim Degtyarev > > In some cases such as JDI API we have the class constant pool content only in form of separate byte array. Currently there is no way to load constant pool from byte array. > The proposed patch add new public constructor to the org.apache.bcel.classfile.ConstantPool that allow loading ConstantPool from byte array representation. > GitHub pull request: https://github.com/apache/commons-bcel/pull/1 -- This message was sent by Atlassian JIRA (v6.3.4#6332)