Return-Path: 
 <issues-return-43660-apmail-commons-issues-archive=commons.apache.org@commons.apache.org>
X-Original-To: apmail-commons-issues-archive@minotaur.apache.org
Delivered-To: apmail-commons-issues-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 7CCEB17863
	for <apmail-commons-issues-archive@minotaur.apache.org>;
 Wed, 15 Oct 2014 20:15:34 +0000 (UTC)
Received: (qmail 38531 invoked by uid 500); 15 Oct 2014 20:15:34 -0000
Delivered-To: apmail-commons-issues-archive@commons.apache.org
Received: (qmail 38422 invoked by uid 500); 15 Oct 2014 20:15:34 -0000
Mailing-List: contact issues-help@commons.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@commons.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@commons.apache.org>
List-Post: <mailto:issues@commons.apache.org>
List-Id: <issues.commons.apache.org>
Reply-To: issues@commons.apache.org
Delivered-To: mailing list issues@commons.apache.org
Received: (qmail 38410 invoked by uid 99); 15 Oct 2014 20:15:34 -0000
Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 15 Oct 2014 20:15:34 +0000
Date: Wed, 15 Oct 2014 20:15:34 +0000 (UTC)
From: "James Sawle (JIRA)" <jira@apache.org>
To: issues@commons.apache.org
Message-ID: <JIRA.12436521.1253810580000.273342.1413404134139@Atlassian.JIRA>
In-Reply-To: <JIRA.12436521.1253810580000@Atlassian.JIRA>
References: <JIRA.12436521.1253810580000@Atlassian.JIRA>
 <JIRA.12436521.1253810580946@arcas>
Subject: [jira] [Updated] (LANG-536) Add isSorted() to ArrayUtils
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


     [ https://issues.apache.org/jira/browse/LANG-536?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

James Sawle updated LANG-536:
-----------------------------
    Attachment:     (was: LANG-536 partial.patch)

> Add isSorted() to ArrayUtils
> ----------------------------
>
>                 Key: LANG-536
>                 URL: https://issues.apache.org/jira/browse/LANG-536
>             Project: Commons Lang
>          Issue Type: New Feature
>          Components: lang.*
>            Reporter: Sergei Ivanov
>            Priority: Minor
>             Fix For: Review Patch
>
>         Attachments: LANG-536.patch, perftest.zip
>
>
> In my unit tests I often need to verify that an array is correctly sorted.
> In order to achieve this, I've got two helper methods as follows.
> Is it possible to integrate these methods into ArrayUtils?
> {code}
>     /**
>      * Checks that the specified array of objects is in an ascending order
>      * according to the specified comparator.  All elements in the array must be
>      * <i>mutually comparable</i> by the specified comparator (that is,
>      * <tt>c.compare(e1, e2)</tt> must not throw a <tt>ClassCastException</tt>
>      * for any elements <tt>e1</tt> and <tt>e2</tt> in the array).
>      *
>      * @param a the array to be checked.
>      * @param c the comparator to determine the order of the array.  A
>      * <tt>null</tt> value indicates that the elements'
>      * {@linkplain Comparable natural ordering} should be used.
>      * @return {@code true}, if the array is sorted; {@code false}, otherwise.
>      * @throws ClassCastException if the array contains elements that are
>      * not <i>mutually comparable</i> using the specified comparator.
>      */
>     public static <T> boolean isSorted(final T[] a, final Comparator<? super T> c) {
>         if (a.length <= 1) {
>             // Empty or singleton arrays are always sorted
>             return true;
>         }
>         // Otherwise, check that every element is not smaller than the previous
>         T previous = a[0];
>         for (int i = 1, n = a.length; i < n; i++) {
>             final T current = a[i];
>             if (c.compare(previous, current) > 0) {
>                 return false;
>             }
>             previous = current;
>         }
>         return true;
>     }
>     /**
>      * Checks that the specified array of objects is in an ascending order,
>      * according to the {@linkplain Comparable natural ordering} of its elements.
>      * All elements in the array must implement the {@link Comparable} interface.
>      * Furthermore, all elements in the array must be <i>mutually comparable</i>
>      * (that is, <tt>e1.compareTo(e2)</tt> must not throw a <tt>ClassCastException</tt>
>      * for any elements <tt>e1</tt> and <tt>e2</tt> in the array).
>      *
>      * @param a the array to be checked.
>      * @return {@code true}, if the array is sorted; {@code false}, otherwise.
>      * @throws ClassCastException if the array contains elements that are not
>      * <i>mutually comparable</i> (for example, strings and integers).
>      */
>     @SuppressWarnings({"unchecked"})
>     public static <T> boolean isSorted(final T[] a) {
>         if (a.length <= 1) {
>             // Empty or singleton arrays are always sorted
>             return true;
>         }
>         // Otherwise, check that every element is not smaller than the previous
>         T previous = a[0];
>         for (int i = 1, n = a.length; i < n; i++) {
>             final T current = a[i];
>             if (((Comparable<? super T>) previous).compareTo(previous) > 0) {
>                 return false;
>             }
>             previous = current;
>         }
>         return true;
>     }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)