commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Duncan Jones (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (LANG-780) Add HashCodeBuilder.append(Enum value)
Date Fri, 10 Oct 2014 06:23:33 GMT

     [ https://issues.apache.org/jira/browse/LANG-780?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Duncan Jones updated LANG-780:
------------------------------
      Description: 
Since Enum's hashCode return different values between calls this can cause different values
if enum appended to HashCodeBuilder 
IMHO adding append for enum would be enough to solve this entirely

{code:java}
public org.apache.commons.lang.builder.HashCodeBuilder append(Enum value)
{
 append(value.name().hashCode());
 return this;
}
{code}


  was:
Since Enum's hashCode return different values between calls this can cause different values
if enum appended to HashCodeBuilder 
IMHO adding append for enum would be enough to solve this entirely

public org.apache.commons.lang.builder.HashCodeBuilder append(Enum value)
{
 append(value.name().hashCode());
 return this;
}



    Fix Version/s:     (was: Patch Needed)
                   Review Patch
          Summary: Add HashCodeBuilder.append(Enum value)  (was: add  public org.apache.commons.lang.builder.HashCodeBuilder
append(Enum value) to HashCodeBuilder )

> Add HashCodeBuilder.append(Enum value)
> --------------------------------------
>
>                 Key: LANG-780
>                 URL: https://issues.apache.org/jira/browse/LANG-780
>             Project: Commons Lang
>          Issue Type: New Feature
>          Components: lang.builder.*
>    Affects Versions: 2.5
>            Reporter: Alex Pokotilo
>             Fix For: Review Patch
>
>         Attachments: LANG-780.patch
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> Since Enum's hashCode return different values between calls this can cause different
values if enum appended to HashCodeBuilder 
> IMHO adding append for enum would be enough to solve this entirely
> {code:java}
> public org.apache.commons.lang.builder.HashCodeBuilder append(Enum value)
> {
>  append(value.name().hashCode());
>  return this;
> }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message