Mailing-List: contact issues-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: issues@commons.apache.org
Date: Thu, 11 Sep 2014 17:44:34 +0000 (UTC)
From: "Sebb (JIRA)" <jira@apache.org>
To: issues@commons.apache.org
Message-ID: <JIRA.12739696.1410017246000.11047.1410457474733@Atlassian.JIRA>
In-Reply-To: <JIRA.12739696.1410017246000@Atlassian.JIRA>
References: <JIRA.12739696.1410017246000@Atlassian.JIRA>
 <JIRA.12739696.1410017246111@arcas>
Subject: [jira] [Comment Edited] (DBUTILS-120) Add loading from SQL file to
 QueryLoader
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/DBUTILS-120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14130364#comment-14130364 ] 

Sebb edited comment on DBUTILS-120 at 9/11/14 5:43 PM:
-------------------------------------------------------

With the original format, a comment of the form "\-xxxxxx:" would match; only the leading "\-" and trailing ":" distinguish it.

With the suggested format, there has to be a leading string of "  Query:", which is less likely to match accidentally

Personally I think Gary's format also looks nicer.
It's also potentially extendable, in case something other than a Query needs to be provided via comments.


was (Author: sebb@apache.org):
With the original format, a comment of the form "-xxxxxx:" would match; only the leading "-" and trailing ":" distinguish it.

With the suggested format, there has to be a leading string of "  Query:", which is less likely to match accidentally

Personally I think Gary's format also looks nicer.
It's also potentially extendable, in case something other than a Query needs to be provided via comments.

> Add loading from SQL file to QueryLoader
> ----------------------------------------
>
>                 Key: DBUTILS-120
>                 URL: https://issues.apache.org/jira/browse/DBUTILS-120
>             Project: Commons DbUtils
>          Issue Type: Improvement
>            Reporter: Aleksei Kovura
>              Labels: patch
>         Attachments: dbutilsQueryLoader.diff
>
>
> I propose sql file in the following format:
> ---queryName1:
> SELECT * FROM "APP"."TABLE1";
> ---queryName2:
> SELECT column1, column2 FROM "APP"."TABLE2" WHERE column1=?;


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)