Return-Path: X-Original-To: apmail-commons-issues-archive@minotaur.apache.org Delivered-To: apmail-commons-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 23D2011C4E for ; Wed, 10 Sep 2014 11:36:29 +0000 (UTC) Received: (qmail 7001 invoked by uid 500); 10 Sep 2014 11:36:29 -0000 Delivered-To: apmail-commons-issues-archive@commons.apache.org Received: (qmail 6903 invoked by uid 500); 10 Sep 2014 11:36:28 -0000 Mailing-List: contact issues-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: issues@commons.apache.org Delivered-To: mailing list issues@commons.apache.org Received: (qmail 6713 invoked by uid 99); 10 Sep 2014 11:36:28 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 10 Sep 2014 11:36:28 +0000 Date: Wed, 10 Sep 2014 11:36:28 +0000 (UTC) From: "Duncan Jones (JIRA)" To: issues@commons.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Resolved] (LANG-1035) Javadoc for EqualsBuilder.reflectionEquals() is unclear MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/LANG-1035?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duncan Jones resolved LANG-1035. -------------------------------- Resolution: Fixed Fix Version/s: (was: Patch Needed) 3.4 Author: djones Date: Wed Sep 10 11:32:53 2014 New Revision: 1623970 URL: http://svn.apache.org/r1623970 Log: Fix for LANG-1035: Javadoc for EqualsBuilder.reflectionEquals() is unclear Modified: commons/proper/lang/trunk/src/changes/changes.xml commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/builder/EqualsBuilder.java > Javadoc for EqualsBuilder.reflectionEquals() is unclear > ------------------------------------------------------- > > Key: LANG-1035 > URL: https://issues.apache.org/jira/browse/LANG-1035 > Project: Commons Lang > Issue Type: Bug > Components: lang.builder.* > Affects Versions: 3.3.2 > Reporter: Duncan Jones > Assignee: Duncan Jones > Fix For: 3.4 > > > The Javadoc for {{EqualsBuilder.reflectionEquals()}} doesn't explain that {{.equals()}} is used to compare non-primitive fields in the class. > Consequently, readers may assume the method recursively builds {{.equals()}} for all fields. We should clarify this. > Related: LANG-1034 -- This message was sent by Atlassian JIRA (v6.3.4#6332)