Mailing-List: contact issues-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: issues@commons.apache.org
Date: Thu, 7 Aug 2014 19:59:12 +0000 (UTC)
From: "Bernd Eckenfels (JIRA)" <jira@apache.org>
To: issues@commons.apache.org
Message-ID: <JIRA.12732582.1407429194785.37219.1407441552066@arcas>
In-Reply-To: <JIRA.12732582.1407429194785@arcas>
References: <JIRA.12732582.1407429194785@arcas>
Subject: [jira] [Comment Edited] (NET-550) Default FTPClient bufferSize
 results in very slow retrieve transfers
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/NET-550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14089704#comment-14089704 ] 

Bernd Eckenfels edited comment on NET-550 at 8/7/14 7:58 PM:
-------------------------------------------------------------

net-buffercopy-ext.patch: Version using 8k, avoiding double-buffering and fixing javadocs. (does not include NET-551)


was (Author: b.eckenfels):
Version using 8k, avoiding double-buffering and fixing javadocs.

> Default FTPClient bufferSize results in very slow retrieve transfers
> --------------------------------------------------------------------
>
>                 Key: NET-550
>                 URL: https://issues.apache.org/jira/browse/NET-550
>             Project: Commons Net
>          Issue Type: Bug
>    Affects Versions: 3.3
>            Reporter: Geoffrey Hardy
>         Attachments: net-buffercopy-ext.patch, net-buffercopy.patch
>
>
> While experimenting with FTPClient, I discovered that if I don't call setBufferSize(), the default value is zero.  This results in retrieveFile() calling the version of InputStream.read() with no parameters, reading one byte at a time.  For comparison, the downloading a CD ISO image of about ~648MB took 18m10s with the default settings.  In contrast, calling setBufferSize(8192) took only 7.9s, an improvement of ~137x.
> Here is some sample code:
> {code:java}
> FTPClient ftp = new FTPClient();
> // ftp.setBufferSize(8192);
> ftp.setControlKeepAliveTimeout(300);
> ftp.setCopyStreamListener(new CopyStreamListener() {
>     @Override
>     public void bytesTransferred(long totalBytesTransferred, int bytesTransferred, long streamSize) {
>         System.out.println("totalBytesTransferred: " + totalBytesTransferred
>             + ", bytesTransferred: " + bytesTransferred + ", streamSize: " + streamSize);
>     }
>     @Override public void bytesTransferred(CopyStreamEvent event) {}
> });
> ftp.connect(host);
> ftp.login(user, pass);
> ftp.retrieveFile(file, outputStream);
> {code}
> The log message from the stream listener printed lots messages "bytesTransferred: 1" and totalBytesTransferred incremented by 1 each time.  This corresponds to the part of the code which reads one byte at a time with {{int inputStream.read()}}.


--
This message was sent by Atlassian JIRA
(v6.2#6252)