Mailing-List: contact issues-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: issues@commons.apache.org
Date: Mon, 25 Aug 2014 06:16:57 +0000 (UTC)
From: "Benedikt Ritter (JIRA)" <jira@apache.org>
To: issues@commons.apache.org
Message-ID: <JIRA.12709513.1398062387927.1466.1408947417812@arcas>
In-Reply-To: <JIRA.12709513.1398062387927@arcas>
References: <JIRA.12709513.1398062387927@arcas>
Subject: [jira] [Commented] (SANDBOX-472) Transformer Registry
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/SANDBOX-472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14108792#comment-14108792 ] 

Benedikt Ritter commented on SANDBOX-472:
-----------------------------------------

Hello [~yogu13],

I've looked into your lastest patch. The TransformerRegistry looks good! But where has the TransformerRegistryTestCase gone? :) It is missing in your patch. Further more I currently don't understand what you're trying to achieve with the TransformerRegistryLoader and the TransformerUtilsBean. 

I don't think that we need the loader. Having an object that handles transforming is maybe a good thing. Although I'd just call it a TransformerBean. Can't we just pass the TransformerRegistry to the TransformerBean? We can provide different implementations of the TransformerRegistry (by extracting an interface), for example one that provide a fluent API for adding additional transformers.

Since I'd like to finally commit party of your hard work, may I ask you to create a patch just containing the TransformerRegistry and the TransformerRegistryTestCase (and test transformers if needed)? We can add that to the code base and then start working on the integration of the registry from there on. WDYT?

Best regards and many thanks for your patience!
Benedikt

> Transformer Registry
> --------------------
>
>                 Key: SANDBOX-472
>                 URL: https://issues.apache.org/jira/browse/SANDBOX-472
>             Project: Commons Sandbox
>          Issue Type: Task
>          Components: BeanUtils2
>    Affects Versions: Nightly Builds
>            Reporter: Yogesh Rao
>            Assignee: Benedikt Ritter
>             Fix For: Nightly Builds
>
>         Attachments: TestStringFloatTransformerImpl.java.txt, TestStringIntegerTransformerImpl.java.txt, TransformerRegistry.java.txt, TransformerRegistryTestCase.java.txt, sandbox-472.patch
>
>
> Hi,
> This is my first development JIRA for BU2 so apologies in case i m missing out on basics. Beanutils1 has a functionality wherein all the converters are registered and are called when conversion in value is required. This functionality is missing for BU2 project. I also saw that BeanUtils1 uses WeakFastHashMap for this, which seems like is having issues across architectures and did see few JIRA's on this. Wanted inputs if having a synchronized instance of WeakHashMap wrapped in the TransformerRegsitry class and providing methods to register, deregister, restoreDefault, lookup be desired?


--
This message was sent by Atlassian JIRA
(v6.2#6252)