Return-Path: X-Original-To: apmail-commons-issues-archive@minotaur.apache.org Delivered-To: apmail-commons-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 84C2A11D9F for ; Thu, 14 Aug 2014 20:08:27 +0000 (UTC) Received: (qmail 37375 invoked by uid 500); 14 Aug 2014 20:08:21 -0000 Delivered-To: apmail-commons-issues-archive@commons.apache.org Received: (qmail 37299 invoked by uid 500); 14 Aug 2014 20:08:21 -0000 Mailing-List: contact issues-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: issues@commons.apache.org Delivered-To: mailing list issues@commons.apache.org Received: (qmail 37140 invoked by uid 99); 14 Aug 2014 20:08:21 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 14 Aug 2014 20:08:21 +0000 Date: Thu, 14 Aug 2014 20:08:21 +0000 (UTC) From: "Benedikt Ritter (JIRA)" To: issues@commons.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Closed] (CSV-70) Improve readability of CSVLexer MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CSV-70?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benedikt Ritter closed CSV-70. ------------------------------ > Improve readability of CSVLexer > ------------------------------- > > Key: CSV-70 > URL: https://issues.apache.org/jira/browse/CSV-70 > Project: Commons CSV > Issue Type: Improvement > Components: Parser > Affects Versions: 1.0 > Reporter: Benedikt Ritter > Fix For: 1.0 > > > There are several things that can be improved in the token lexer (this has also been discussed on ML, see http://markmail.org/thread/c6x5ji4v44nx5k4h): > * Remove Token input parameter in nextToken() (x) this makes lexer slower > * Add convenience methods isDelimiter(c) and isEncapsulator(c) (/) > * Remove current caracter input parameter from methods (/) > * If possible: replace while(true) loops -- This message was sent by Atlassian JIRA (v6.2#6252)