commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sebb (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (VALIDATOR-340) Add new TLDs
Date Tue, 19 Aug 2014 15:05:18 GMT

    [ https://issues.apache.org/jira/browse/VALIDATOR-340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14102286#comment-14102286
] 

Sebb commented on VALIDATOR-340:
--------------------------------

It might make sense to provide the TLDs as a resource file, rather than embedding the strings
as constants.
[Likewise for the country codes, though these change less frequently]
This could allow users to replace the file if necessary without needing to download a new
version of the code.

A crude way to do this would be to replace the resource file in the jar.
It would be better if the user could provide a resource file with any required additions.
Not sure if there is a use-case for dropping TLDs.

Note that EmailValidator now uses DomainValidator to check the domain string.

> Add new TLDs
> ------------
>
>                 Key: VALIDATOR-340
>                 URL: https://issues.apache.org/jira/browse/VALIDATOR-340
>             Project: Commons Validator
>          Issue Type: Improvement
>          Components: Framework
>    Affects Versions: 1.4.0 Release
>         Environment: Live
>            Reporter: Ken Montgomery
>              Labels: TLD, domains, email
>             Fix For: 1.4.1
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> The current commons-validator-1.4.0.jar does not include any domains released after 2012.
> org.apache.commons.validator.routines.EmailValidator;
> Then on to the method isValidGenericTld(tld)
> Which uses the list
> private static final String[] GENERIC_TLDS = new String[] {
> "aero", // air transport industry
> "asia", // Pan-Asia/Asia Pacific
> "biz", // businesses
> "cat", // Catalan linguistic/cultural community
> "com", // commercial enterprises
> "coop", // cooperative associations
> "info", // informational sites
> "jobs", // Human Resource managers
> "mobi", // mobile products and services
> "museum", // museums, surprisingly enough
> "name", // individuals' sites
> "net", // internet support infrastructure/business
> "org", // noncommercial organizations
> "pro", // credentialed professionals and entities
> "tel", // contact data for businesses and individuals
> "travel", // entities in the travel industry
> "gov", // United States Government
> "edu", // accredited postsecondary US education entities
> "mil", // United States Military
> "int" // organizations established by international treaty
> };
> This list does not include any of the new domains. They are therefore seen as invalid.
> See New Domains (about 300) http://newgtlds.icann.org/en/program-status/delegated-strings
> From http://commons.apache.org/proper/commons-validator/changes-report.html
> I can see that version 1.4.0 is the current version even though it was released on 2012-02-03



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message