commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sebb (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (POOL-268) Remove throws <RuntimeException> from all method signatures
Date Mon, 18 Aug 2014 17:00:22 GMT

    [ https://issues.apache.org/jira/browse/POOL-268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14100853#comment-14100853
] 

Sebb commented on POOL-268:
---------------------------

Here is one of the methods in java.lang.Integer:

{code}
public static int parseInt(String s) throws NumberFormatException
{code}

That is an RTE and it's recoverable in many cases.

> Remove throws <RuntimeException> from all method signatures
> -----------------------------------------------------------
>
>                 Key: POOL-268
>                 URL: https://issues.apache.org/jira/browse/POOL-268
>             Project: Commons Pool
>          Issue Type: Improvement
>    Affects Versions: 2.2
>            Reporter: Michael Osipov
>
> Unfortunately, many signatures carry a {{throws <RuntimeException>}} like {{IllegalStateException}},
etc. This is incorrect. A runtime exception never appears in the signature but only in the
Javadocs because runtime exception indicate a programming error.
> This violates against Java programming rules and Joshua Bloch's Effective Java.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message