commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benedikt Ritter (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (SANDBOX-472) Add a registry for Transformer implementations
Date Mon, 25 Aug 2014 15:15:58 GMT

    [ https://issues.apache.org/jira/browse/SANDBOX-472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14109186#comment-14109186
] 

Benedikt Ritter edited comment on SANDBOX-472 at 8/25/14 3:14 PM:
------------------------------------------------------------------

{code}
$ svn ci -m "SANDBOX-472: Add a registry for Transformer implementations. Thanks to Yogesh
Rao."
Sending        src/changes/changes.xml
Adding         src/main/java/org/apache/commons/beanutils2/TransformerRegistry.java
Adding         src/test/java/org/apache/commons/beanutils2/TransformerRegistryTestCase.java
Adding         src/test/java/org/apache/commons/beanutils2/testtransformers
Adding         src/test/java/org/apache/commons/beanutils2/testtransformers/TestStringFloatTransformer.java
Adding         src/test/java/org/apache/commons/beanutils2/testtransformers/TestStringIntegerTransformer.java
Transmitting file data .....
Committed revision 1620336.
{code}

I have applied the TransformerRegistry patch. Now we can start integration into the rest of
the code. Let's use a new ticket for that purpose.

Thanks!


was (Author: britter):
{code}
$ svn ci -m "SANDBOX-472: Add a registry for Transformer implementations. Thanks to Yogesh
Rao."
Sending        src/changes/changes.xml
Adding         src/main/java/org/apache/commons/beanutils2/TransformerRegistry.java
Adding         src/test/java/org/apache/commons/beanutils2/TransformerRegistryTestCase.java
Adding         src/test/java/org/apache/commons/beanutils2/testtransformers
Adding         src/test/java/org/apache/commons/beanutils2/testtransformers/TestStringFloatTransformer.java
Adding         src/test/java/org/apache/commons/beanutils2/testtransformers/TestStringIntegerTransformer.java
Transmitting file data .....
Committed revision 1620336.
{code}

I have applied the TransformerRegistry patch, although there is some additional work to do.
For example the lookup method still takes Class parameters rather then Type parameters, leading
to util methods like the one in the TransformerRegistryTestCase. Very good work nontheless.
Now we can start integration into the rest of the code. Let's use a new ticket for that purpose.

Thanks!

> Add a registry for Transformer implementations
> ----------------------------------------------
>
>                 Key: SANDBOX-472
>                 URL: https://issues.apache.org/jira/browse/SANDBOX-472
>             Project: Commons Sandbox
>          Issue Type: Task
>          Components: BeanUtils2
>    Affects Versions: Nightly Builds
>            Reporter: Yogesh Rao
>            Assignee: Benedikt Ritter
>             Fix For: Nightly Builds
>
>         Attachments: TestStringFloatTransformerImpl.java.txt, TestStringIntegerTransformerImpl.java.txt,
TransformerRegistry.java.txt, TransformerRegistryTestCase.java.txt, sandbox-472.patch
>
>
> Hi,
> This is my first development JIRA for BU2 so apologies in case i m missing out on basics.
Beanutils1 has a functionality wherein all the converters are registered and are called when
conversion in value is required. This functionality is missing for BU2 project. I also saw
that BeanUtils1 uses WeakFastHashMap for this, which seems like is having issues across architectures
and did see few JIRA's on this. Wanted inputs if having a synchronized instance of WeakHashMap
wrapped in the TransformerRegsitry class and providing methods to register, deregister, restoreDefault,
lookup be desired?



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message