commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stagiaire inria lille dascq (JIRA)" <j...@apache.org>
Subject [jira] [Created] (LANG-1028) CLONE - StringUtils.countMatches loops forever if substring empty
Date Tue, 15 Jul 2014 09:35:05 GMT
stagiaire inria lille dascq created LANG-1028:
-------------------------------------------------

             Summary: CLONE - StringUtils.countMatches loops forever if substring empty
                 Key: LANG-1028
                 URL: https://issues.apache.org/jira/browse/LANG-1028
             Project: Commons Lang
          Issue Type: Bug
          Components: lang.*
         Environment: Operating System: Linux
Platform: PC
            Reporter: stagiaire inria lille dascq


If you do say StringUtils.countMatches("x", ""), then it goes into an infinite loop.

Also sub isn't checked for null if str is null also. For instance
StringUtils.countMatches(null, null) should throw an NPE instead of 0.

To fix both problems put the following code at the start of the method:

        if (sub.equals("")) {
            return 0;
        }



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message