Return-Path: X-Original-To: apmail-commons-issues-archive@minotaur.apache.org Delivered-To: apmail-commons-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 774511153C for ; Wed, 11 Jun 2014 09:36:04 +0000 (UTC) Received: (qmail 81175 invoked by uid 500); 11 Jun 2014 09:36:04 -0000 Delivered-To: apmail-commons-issues-archive@commons.apache.org Received: (qmail 81079 invoked by uid 500); 11 Jun 2014 09:36:04 -0000 Mailing-List: contact issues-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: issues@commons.apache.org Delivered-To: mailing list issues@commons.apache.org Received: (qmail 81064 invoked by uid 99); 11 Jun 2014 09:36:04 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 11 Jun 2014 09:36:04 +0000 Date: Wed, 11 Jun 2014 09:36:04 +0000 (UTC) From: "Thomas Neidhart (JIRA)" To: issues@commons.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CODEC-187) Beider Morse Phonetic Matching producing incorrect tokens MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CODEC-187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14027575#comment-14027575 ] Thomas Neidhart commented on CODEC-187: --------------------------------------- Fixing the bug is simple. What would be helpful is to have a set of tokens to compare the results with the original implementation and our code. You started with this in your post, but it would be good to have a proper unit test for this. Regarding the license issue: commons is a project with developers all around the world which are living in different timezones, so it usually takes some time until all involved people had a chance to take a look. > Beider Morse Phonetic Matching producing incorrect tokens > --------------------------------------------------------- > > Key: CODEC-187 > URL: https://issues.apache.org/jira/browse/CODEC-187 > Project: Commons Codec > Issue Type: Bug > Affects Versions: 1.9 > Reporter: michael tobias > Priority: Minor > > I believe the Beider Morse Phonetic Matching algorithm was added in Commons Codec 1.6 > The BMPM algorithm is an EVOLVING algorithm that is currently on version 3.02 though it had been static since version 3.01 dated 19 Dec 2011 (it was first available as opensource as version 1.00 on 6 May 2009). > I can see nothing in the Commons Codec Docs to say which version of BMPM was implemented so I am not sure if the problem with the algorithm as coded in the Codec is simply an old version or whether there are more basic problems with the implementation. > How do I determine the version of the algorithm that was implemented in the Commons Codec? > How do we ensure that the algorithm is updated if/when the BMPM algorithm changes? > How do we ensure that the algorithm as coded in the Commons Codec is accurate and working as expected? -- This message was sent by Atlassian JIRA (v6.2#6252)