commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sebb (JIRA)" <j...@apache.org>
Subject [jira] [Created] (IO-447) Possible NPE in FileSystemUtils.freeSpaceWindows; FilenameUtils.normalize can return null
Date Tue, 03 Jun 2014 22:13:02 GMT
Sebb created IO-447:
-----------------------

             Summary: Possible NPE in FileSystemUtils.freeSpaceWindows; FilenameUtils.normalize
can return null
                 Key: IO-447
                 URL: https://issues.apache.org/jira/browse/IO-447
             Project: Commons IO
          Issue Type: Bug
            Reporter: Sebb


There is a possible NPE in FileSystemUtils.freeSpaceWindows.
FilenameUtils.normalize can return null so the path.length() will NPE

For example, ".." returns null.

I'm not entirely sure why the path needs to be normalised, apart from converting / to \. Even
that seems a bit dubious - why should the user want to return the freespace for a Unix-style
path on a Windows system?

And if it does need to be normalised, why not use the File class, which handles / to \ conversion
transparently?

A short term fix would be to return IAE for paths that normalise to null.
However that would not allow the use of paths such as ".." - though at least that would not
cause NPE.




--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message