Mailing-List: contact issues-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: issues@commons.apache.org
Date: Fri, 2 May 2014 17:11:15 +0000 (UTC)
From: "Benedikt Ritter (JIRA)" <jira@apache.org>
To: issues@commons.apache.org
Message-ID: <JIRA.12711585.1398892303303.220945.1399050675141@arcas>
In-Reply-To: <JIRA.12711585.1398892303303@arcas>
References: <JIRA.12711585.1398892303303@arcas>
Subject: [jira] [Comment Edited] (LANG-1004)
 DurationFormatUtils#formatDurationHMS implementation does not correspond to
 Javadoc and vice versa
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/LANG-1004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13987919#comment-13987919 ] 

Benedikt Ritter edited comment on LANG-1004 at 5/2/14 5:10 PM:
---------------------------------------------------------------

Hi Michael,

nice patch! However I'm a bit afraid this change will break clients that are using the method as it is now. What do you think? The main use case is probably formatting for displaying a value (in the GUI or in some kind of log file). So it may not be a problem?

Benedikt

EDIT: how about providing a new method called {{formatDurationISOHMS}} which formats the way you propose?


was (Author: britter):
Hi Michael,

nice patch! However I'm a bit afraid this change will break clients that are using the method as it is now. What do you think? The main use case is probably formatting for displaying a value (in the GUI or in some kind of log file). So it may not be a problem?

Benedikt

> DurationFormatUtils#formatDurationHMS implementation does not correspond to Javadoc and vice versa
> --------------------------------------------------------------------------------------------------
>
>                 Key: LANG-1004
>                 URL: https://issues.apache.org/jira/browse/LANG-1004
>             Project: Commons Lang
>          Issue Type: Bug
>          Components: lang.text.*
>    Affects Versions: 3.3.2
>            Reporter: Michael Osipov
>             Fix For: Patch Needed
>
>         Attachments: LANG-1004.patch
>
>
> This method has several flaws:
> 1. Javadoc says: "The format used is ISO8601-like: H:m:s.S." but the method call supplies "H:mm:ss.SSS"
> 2. ISO time never omits leading zeros, so the proper pattern must be "HH:mm:ss.SSS"
> 3. The method name says: "HMS" but includes the second fraction.
> Since the use of fractions is optional, the method should use "HH:mm:ss" and update the Javadoc as well.


--
This message was sent by Atlassian JIRA
(v6.2#6252)