Return-Path: X-Original-To: apmail-commons-issues-archive@minotaur.apache.org Delivered-To: apmail-commons-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 1E49A10584 for ; Sat, 31 May 2014 05:08:02 +0000 (UTC) Received: (qmail 31138 invoked by uid 500); 31 May 2014 04:08:02 -0000 Delivered-To: apmail-commons-issues-archive@commons.apache.org Received: (qmail 31028 invoked by uid 500); 31 May 2014 04:08:02 -0000 Mailing-List: contact issues-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: issues@commons.apache.org Delivered-To: mailing list issues@commons.apache.org Received: (qmail 30969 invoked by uid 99); 31 May 2014 04:08:02 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 31 May 2014 04:08:02 +0000 Date: Sat, 31 May 2014 04:08:02 +0000 (UTC) From: "Phil Steitz (JIRA)" To: issues@commons.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Closed] (DBCP-404) Mutable fields should be private MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/DBCP-404?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Phil Steitz closed DBCP-404. ---------------------------- > Mutable fields should be private > -------------------------------- > > Key: DBCP-404 > URL: https://issues.apache.org/jira/browse/DBCP-404 > Project: Commons Dbcp > Issue Type: Bug > Reporter: Sebb > Fix For: 2.0 > > > Non-private mutable fields make thread-safety harder. > Make all mutable fields private (or at worst package-protected), and use getters/setters for access if necessary. > This allows synchronisation to be easily added later if necessary, as well as potentially allowing validation of values. -- This message was sent by Atlassian JIRA (v6.2#6252)