commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Lukáš Petrovický (JIRA) <j...@apache.org>
Subject [jira] [Updated] (IO-444) Convert Tailer to ScheduledExecutorService
Date Sat, 17 May 2014 15:27:14 GMT

     [ https://issues.apache.org/jira/browse/IO-444?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Lukáš Petrovický updated IO-444:
--------------------------------

    Description: 
I have provided a pull request that converts Tailer to java.util.concurrent.ScheduledExecutorService:
https://github.com/apache/commons-io/pull/2

This has multiple benefits:

- it provides periodic runs of the read operations without needing to invoke Thread.sleep().
- it removes any looping from the run() method, making for cleaner code.
- generally brings Tailer closer to what modern Java looks like.

No public API changes have been made. All tests are passing without modifications. I kindly
ask you to merge it.

  was:
I have provided a pull request that converts Tailer to java.util.concurrent.ScheduledExecutorService:
https://github.com/apache/commons-io/pull/2

This has multiple benefits:

it provides periodic runs of the read operations without needing to invoke Thread.sleep().
it removes any looping from the run() method, making for cleaner code.
generally brings Tailer closer to what modern Java looks like.
No public API changes have been made. All tests are passing without
modifications.

I kindly ask you to merge it.


> Convert Tailer to ScheduledExecutorService
> ------------------------------------------
>
>                 Key: IO-444
>                 URL: https://issues.apache.org/jira/browse/IO-444
>             Project: Commons IO
>          Issue Type: Improvement
>          Components: Utilities
>    Affects Versions: 2.5
>            Reporter: Lukáš Petrovický
>            Priority: Minor
>
> I have provided a pull request that converts Tailer to java.util.concurrent.ScheduledExecutorService:
> https://github.com/apache/commons-io/pull/2
> This has multiple benefits:
> - it provides periodic runs of the read operations without needing to invoke Thread.sleep().
> - it removes any looping from the run() method, making for cleaner code.
> - generally brings Tailer closer to what modern Java looks like.
> No public API changes have been made. All tests are passing without modifications. I
kindly ask you to merge it.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message