commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (COLLECTIONS-521) Typo in MultiMapKey's isEqualKey(entry, key1, key2)
Date Thu, 01 May 2014 21:02:14 GMT

    [ https://issues.apache.org/jira/browse/COLLECTIONS-521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13986987#comment-13986987
] 

ASF GitHub Bot commented on COLLECTIONS-521:
--------------------------------------------

GitHub user maximenay opened a pull request:

    https://github.com/apache/commons-collections/pull/1

    COLLECTIONS-521 Typo in MultiMapKey's isEqualKey(entry, key1, key2)

    https://issues.apache.org/jira/browse/COLLECTIONS-521

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/maximenay/commons-collections trunk

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/commons-collections/pull/1.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1
    
----
commit 2992bbb3d7e772a43ab5e819bd73dd211fcf7681
Author: maxime nay <maxime.nay@gmail.com>
Date:   2014-05-01T20:59:34Z

    COLLECTIONS-521 Typo in MultiMapKey's isEqualKey(entry, key1, key2)

----


> Typo in MultiMapKey's isEqualKey(entry, key1, key2)
> ---------------------------------------------------
>
>                 Key: COLLECTIONS-521
>                 URL: https://issues.apache.org/jira/browse/COLLECTIONS-521
>             Project: Commons Collections
>          Issue Type: Bug
>            Reporter: Maxime Nay
>
> I believe there is a typo line 252 in MultiKeyMap.
>         return
>             multi.size() == 2 &&
>             (key1 == multi.getKey(0) || key1 != null && key1.equals(multi.getKey(0)))
&&
>             (key2 == multi.getKey(1) || key1 != null && key2.equals(multi.getKey(1)));
> should be:
>         return
>             multi.size() == 2 &&
>             (key1 == multi.getKey(0) || key1 != null && key1.equals(multi.getKey(0)))
&&
>             (key2 == multi.getKey(1) || key2 != null && key2.equals(multi.getKey(1)));



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message