commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Osipov (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LANG-1004) DurationFormatUtils#formatDurationHMS implementation does not correspond to Javadoc and vice versa
Date Sun, 04 May 2014 18:29:15 GMT

    [ https://issues.apache.org/jira/browse/LANG-1004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13989081#comment-13989081
] 

Michael Osipov commented on LANG-1004:
--------------------------------------

With pleasure, being a Commons Lang user for several years and an Apache Maven committer,
that

> DurationFormatUtils#formatDurationHMS implementation does not correspond to Javadoc and
vice versa
> --------------------------------------------------------------------------------------------------
>
>                 Key: LANG-1004
>                 URL: https://issues.apache.org/jira/browse/LANG-1004
>             Project: Commons Lang
>          Issue Type: Bug
>          Components: lang.text.*
>    Affects Versions: 3.3.2
>            Reporter: Michael Osipov
>            Assignee: Benedikt Ritter
>             Fix For: 3.4
>
>         Attachments: LANG-1004.patch
>
>
> This method has several flaws:
> 1. Javadoc says: "The format used is ISO8601-like: H:m:s.S." but the method call supplies
"H:mm:ss.SSS"
> 2. ISO time never omits leading zeros, so the proper pattern must be "HH:mm:ss.SSS"
> 3. The method name says: "HMS" but includes the second fraction.
> Since the use of fractions is optional, the method should use "HH:mm:ss" and update the
Javadoc as well.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message