commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benedikt Ritter (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LANG-1004) DurationFormatUtils#formatDurationHMS implementation does not correspond to Javadoc and vice versa
Date Fri, 02 May 2014 17:08:14 GMT

    [ https://issues.apache.org/jira/browse/LANG-1004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13987919#comment-13987919
] 

Benedikt Ritter commented on LANG-1004:
---------------------------------------

Hi Michael,

nice patch! However I'm a bit afraid this change will break clients that are using the method
as it is now. What do you think? The main use case is probably formatting for displaying a
value (in the GUI or in some kind of log file). So it may not be a problem?

Benedikt

> DurationFormatUtils#formatDurationHMS implementation does not correspond to Javadoc and
vice versa
> --------------------------------------------------------------------------------------------------
>
>                 Key: LANG-1004
>                 URL: https://issues.apache.org/jira/browse/LANG-1004
>             Project: Commons Lang
>          Issue Type: Bug
>          Components: lang.text.*
>    Affects Versions: 3.3.2
>            Reporter: Michael Osipov
>             Fix For: Patch Needed
>
>         Attachments: LANG-1004.patch
>
>
> This method has several flaws:
> 1. Javadoc says: "The format used is ISO8601-like: H:m:s.S." but the method call supplies
"H:mm:ss.SSS"
> 2. ISO time never omits leading zeros, so the proper pattern must be "HH:mm:ss.SSS"
> 3. The method name says: "HMS" but includes the second fraction.
> Since the use of fractions is optional, the method should use "HH:mm:ss" and update the
Javadoc as well.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message