commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Phil Steitz (JIRA)" <j...@apache.org>
Subject [jira] [Closed] (DBCP-404) Mutable fields should be private
Date Sat, 31 May 2014 04:08:02 GMT

     [ https://issues.apache.org/jira/browse/DBCP-404?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Phil Steitz closed DBCP-404.
----------------------------


> Mutable fields should be private
> --------------------------------
>
>                 Key: DBCP-404
>                 URL: https://issues.apache.org/jira/browse/DBCP-404
>             Project: Commons Dbcp
>          Issue Type: Bug
>            Reporter: Sebb
>             Fix For: 2.0
>
>
> Non-private mutable fields make thread-safety harder.
> Make all mutable fields private (or at worst package-protected), and use getters/setters
for access if necessary.
> This allows synchronisation to be easily added later if necessary, as well as potentially
allowing validation of values.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message