Return-Path: 
 <issues-return-40977-apmail-commons-issues-archive=commons.apache.org@commons.apache.org>
X-Original-To: apmail-commons-issues-archive@minotaur.apache.org
Delivered-To: apmail-commons-issues-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 919731166F
	for <apmail-commons-issues-archive@minotaur.apache.org>;
 Thu, 24 Apr 2014 12:47:41 +0000 (UTC)
Received: (qmail 22940 invoked by uid 500); 24 Apr 2014 12:47:16 -0000
Delivered-To: apmail-commons-issues-archive@commons.apache.org
Received: (qmail 22840 invoked by uid 500); 24 Apr 2014 12:47:15 -0000
Mailing-List: contact issues-help@commons.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@commons.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@commons.apache.org>
List-Post: <mailto:issues@commons.apache.org>
List-Id: <issues.commons.apache.org>
Reply-To: issues@commons.apache.org
Delivered-To: mailing list issues@commons.apache.org
Received: (qmail 22826 invoked by uid 99); 24 Apr 2014 12:47:15 -0000
Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 24 Apr 2014 12:47:15 +0000
Date: Thu, 24 Apr 2014 12:47:15 +0000 (UTC)
From: "Emmanuel Bourg (JIRA)" <jira@apache.org>
To: issues@commons.apache.org
Message-ID: <JIRA.12619201.1069133704000.171783.1398343635363@arcas>
In-Reply-To: <JIRA.12619201.1069133704000@arcas>
References: <JIRA.12619201.1069133704000@arcas>
Subject: [jira] [Updated] (BCEL-35) Suggestion to solve the Problem with
 generic.Instruction in Turkish locale
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


     [ https://issues.apache.org/jira/browse/BCEL-35?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Emmanuel Bourg updated BCEL-35:
-------------------------------

         Priority: Major
      Environment:     (was: Operating System: other
Platform: PC)
    Fix Version/s: 5.2
         Priority:   (was: P3)
         Severity:   (was: normal)

> Suggestion to solve the Problem with generic.Instruction in Turkish locale
> --------------------------------------------------------------------------
>
>                 Key: BCEL-35
>                 URL: https://issues.apache.org/jira/browse/BCEL-35
>             Project: Commons BCEL
>          Issue Type: Bug
>          Components: Main
>    Affects Versions: 5.1
>            Reporter: Erik Hilsdale
>            Assignee: Apache Commons Developers
>             Fix For: 5.2
>
>         Attachments: LocaleTest.java, bcel-patch.txt
>
>
> The method 
>     generic.Instruction.readInstruction()
> calls 
>     generic.Instruction.className(short)
> which uses toUpperCase() in its implementation.  
> This is brittle; in the Turkish locale, for example
>  "I".toLowerCase() != "i" 
>  "i".toUpperCase() != "I"
> This was reported to me at the AspectJ project from an actual user who 
> gets 
> org.apache.bcel.generic.ClassGenException: Illegal opcode detected.
> 	at org.apache.bcel.generic.Instruction.readInstruction
> (Instruction.java:189)
> 	at org.apache.bcel.generic.InstructionList.<init>
> (InstructionList.java:193)
> when using AspectJ (which uses BCEL) under the Turkish locale.  So this
> is a problem that's appearing in the wild *smile*.
> I may get around to patching it myself before our next release,
> in which case I'll probably just rip out the Class.forName stuff inside
>     Instruction.readInstruction()
> which is the thing really causing the problem (is that there for expansion,
> in case users define their own bytecodes?  I'm confused as to why there
> isn't just a 256-wide dispatch).



--
This message was sent by Atlassian JIRA
(v6.2#6252)