commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Stefan Bodewig (JIRA)" <>
Subject [jira] [Commented] (COMPRESS-277) IOUtils.skip does not work as advertised
Date Sun, 13 Apr 2014 04:08:14 GMT


Stefan Bodewig commented on COMPRESS-277:

Yes, you are right.

I didn't use a shared array because I didn't want to introduce any form of thread  control
- I completely missed the fact that there is no harm in concurrent writes to the array.

svn revision 1586919

> IOUtils.skip does not work as advertised
> ----------------------------------------
>                 Key: COMPRESS-277
>                 URL:
>             Project: Commons Compress
>          Issue Type: Bug
>    Affects Versions: 1.8
>            Reporter: Fabian Lange
>             Fix For: 1.9
> I am trying to feed a TarInputStream from a CipherInputStream.
> It does not work, because IOUtils.skip() does not adhere to the contract it claims in
> "     * <p>This method will only skip less than the requested number of
>      * bytes if the end of the input stream has been reached.</p>"
> However it does:
>             long skipped = input.skip(numToSkip);
>             if (skipped == 0) {
>                 break;
>             }
> And the input stream javadoc says:
> "     * This may result from any of a number of conditions; reaching end of file
>      * before <code>n</code> bytes have been skipped is only one possibility."
> In the case of CipherInputStream, it stops at the end of each byte buffer.
> If you check the IOUtils from colleagues at commons-io, they have considered this case
in IOUtils.skip() where they use a read to skip through the stream.
> An optimized version could combine trying to skip, then read then trying to skip again.

This message was sent by Atlassian JIRA

View raw message