commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sebb (JIRA)" <j...@apache.org>
Subject [jira] [Created] (NET-534) Unnecesssary call to getReplyString() if no listeners configured
Date Wed, 09 Apr 2014 22:27:15 GMT
Sebb created NET-534:
------------------------

             Summary: Unnecesssary call to getReplyString() if no listeners configured
                 Key: NET-534
                 URL: https://issues.apache.org/jira/browse/NET-534
             Project: Commons Net
          Issue Type: New Feature
          Components: IMAP
            Reporter: Sebb
            Priority: Minor


IMAP methods can return large amounts of data.

The IMap.__getReply() method collects all the reply lines in a list which is converted to
a string before being passed to SocketClient#fireReplyReceived(int, String). 

If there are no listeners, the string conversion is unnecessary, and could be very expensive.

The fireReplyReceived method could be overridden to avoid this.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message