commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sebb (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (JCS-112) RemoteCacheServer.logUpdateInfo bug updating put count
Date Thu, 03 Apr 2014 14:36:17 GMT

    [ https://issues.apache.org/jira/browse/JCS-112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13958861#comment-13958861
] 

Sebb commented on JCS-112:
--------------------------

Meant to add that this is probably the cause of the Continuum unit test failures, though I
don't know why the logging level is different from when the code is run locally.

> RemoteCacheServer.logUpdateInfo bug updating put count
> ------------------------------------------------------
>
>                 Key: JCS-112
>                 URL: https://issues.apache.org/jira/browse/JCS-112
>             Project: Commons JCS
>          Issue Type: Bug
>            Reporter: Sebb
>
> The method RemoteCacheServer.logUpdateInfo contains the code:
> {code}
> if ( log.isInfoEnabled() )
> {
>     // not thread safe, but it doesn't have to be accurate
>     puts++;
>     if ( puts % logInterval == 0 )
>     {
>         log.info( "puts = " + puts );
>     }
> }
> {code}
> This looks wrong - why is the put counter only update if logging is enabled?
> Looks like the issue occurred in r436643 where the getPutCount() method was added. Up
until this point the puts field was only used in the above logging method, so it made sense
to confine the updates to the logging conditional statement.
> However, now the count is used for unit tests, so it needs to be independent of the logging
level.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message