Mailing-List: contact issues-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: issues@commons.apache.org
Date: Sun, 16 Mar 2014 19:34:42 +0000 (UTC)
From: "Andre Diermann (JIRA)" <jira@apache.org>
To: issues@commons.apache.org
Message-ID: <JIRA.12701690.1394900546447.86593.1394998482875@arcas>
In-Reply-To: <JIRA.12701690.1394900546447@arcas>
References: <JIRA.12701690.1394900546447@arcas>
Subject: [jira] [Commented] (SANDBOX-471) Typos and codestyle violations
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/SANDBOX-471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13937295#comment-13937295 ] 

Andre Diermann commented on SANDBOX-471:
----------------------------------------

Very strange! I am using the codestyle from maven [1], where SPACE_WITHIN_ANNOTATION_PARENTHESES is set to true. When I enable/disable this option in the preferences of IntelliJ the preview shows the correct behavior. But when I add the spaces in code and do code formatting the spaces are removed?!?!

So you are totally right! Regarding the white spaces rule from [2] there should be spaces between the braces. I really don't know why IntelliJ removes the spaces.

Big sorry for inconvenience! I will update the patch ASAP.

[1] https://maven.apache.org/developers/maven-idea-codestyle.xml
[2] https://maven.apache.org/developers/conventions/code.html

> Typos and codestyle violations
> ------------------------------
>
>                 Key: SANDBOX-471
>                 URL: https://issues.apache.org/jira/browse/SANDBOX-471
>             Project: Commons Sandbox
>          Issue Type: Improvement
>          Components: BeanUtils2
>            Reporter: Andre Diermann
>            Priority: Minor
>         Attachments: Commons-Sandbox-471.patch
>
>
> The GetPropertyTestCase contained two typos in method names and some codestyle violations in regards to Maven codestyle.
> This patch corrected the typos and reformatted the code.
> (Since it's a small and minor priority patch I hope it's ok to do both in one patch?!)


--
This message was sent by Atlassian JIRA
(v6.2#6252)