commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andre Diermann (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SANDBOX-471) Typos and codestyle violations
Date Sun, 16 Mar 2014 19:34:42 GMT

    [ https://issues.apache.org/jira/browse/SANDBOX-471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13937295#comment-13937295
] 

Andre Diermann commented on SANDBOX-471:
----------------------------------------

Very strange! I am using the codestyle from maven [1], where SPACE_WITHIN_ANNOTATION_PARENTHESES
is set to true. When I enable/disable this option in the preferences of IntelliJ the preview
shows the correct behavior. But when I add the spaces in code and do code formatting the spaces
are removed?!?!

So you are totally right! Regarding the white spaces rule from [2] there should be spaces
between the braces. I really don't know why IntelliJ removes the spaces.

Big sorry for inconvenience! I will update the patch ASAP.

[1] https://maven.apache.org/developers/maven-idea-codestyle.xml
[2] https://maven.apache.org/developers/conventions/code.html

> Typos and codestyle violations
> ------------------------------
>
>                 Key: SANDBOX-471
>                 URL: https://issues.apache.org/jira/browse/SANDBOX-471
>             Project: Commons Sandbox
>          Issue Type: Improvement
>          Components: BeanUtils2
>            Reporter: Andre Diermann
>            Priority: Minor
>         Attachments: Commons-Sandbox-471.patch
>
>
> The GetPropertyTestCase contained two typos in method names and some codestyle violations
in regards to Maven codestyle.
> This patch corrected the typos and reformatted the code.
> (Since it's a small and minor priority patch I hope it's ok to do both in one patch?!)



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message