commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andre Diermann (JIRA)" <>
Subject [jira] [Commented] (SANDBOX-463) Implementation of property paths
Date Sat, 08 Mar 2014 14:33:42 GMT


Andre Diermann commented on SANDBOX-463:

Hello Benedikt,

many thanks for reviewing the patch and for your feedback! :)

In Commons-Sandbox-463#2.patch you will find your proposed improvements. I furthermore resolved
13 checkstyle violations (thanks to your fix of mvn site :)) and changed the order of two
method declarations.

One remark: I am not totally sure about the correct syntax of keys for mapped properties.
From the BU1 code it seems that every character is valid. But I specified it as "([a-z]+[A-Za-z]*)\\(([A-Za-z0-9\\s]+)\\)",
which means only "[A-Za-z0-9\\s]+" is valid as key names, which is more restrictive. I feel
that this might be an issue in the future. What do you think?


[2] see next() in

> Implementation of property paths 
> ---------------------------------
>                 Key: SANDBOX-463
>                 URL:
>             Project: Commons Sandbox
>          Issue Type: Improvement
>          Components: BeanUtils2
>            Reporter: Andre Diermann
>         Attachments: Commons-Sandbox-463#2.patch, Commons-Sandbox-463.patch
> In [1] Benedikt Ritter mentioned the lag of BU1's property path for BU2.
> The attached patch contains an implementation of a PropertyInterpreter - following the
GOF Interpreter Pattern - which is able to interpret simple/index/mapped/nested properties
and any combination of it. The result is a BeanAccessor. The idea is to use the PropertyInterpreter
inside of a BeanAccessor implementation.
> The patch also contains a corresponding test case.
> Example:
> on( anyBean ).set( "contact[15].address(home).street" ).with( "Example Street 1000" );
> [1]

This message was sent by Atlassian JIRA

View raw message