commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benedikt Ritter (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SANDBOX-463) Implementation of property paths
Date Sat, 08 Mar 2014 12:20:42 GMT

    [ https://issues.apache.org/jira/browse/SANDBOX-463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13924815#comment-13924815
] 

Benedikt Ritter commented on SANDBOX-463:
-----------------------------------------

Hello André,

very nice (almost perfect ;-) ) patch! A nice implementation of the interpreter pattern. The
code you wrote is much clearer than the one we use in BeanUtils1. I found two things:

# Every source file has to have the Apache license header at it's top so that it can be added.
Please copy paste the header from one of the existing files and move it below the package
declaration.
# Every text file in svn should end with an empty line. If there is no empty line at the end,
if you append something to the last line, SVN will have a change in the last line, because
when appending to a file you add a new line character to the last line of the file.

Can you resubmit the patch with these two changes?

TIA and keep up the good work!
Benedikt

> Implementation of property paths 
> ---------------------------------
>
>                 Key: SANDBOX-463
>                 URL: https://issues.apache.org/jira/browse/SANDBOX-463
>             Project: Commons Sandbox
>          Issue Type: Improvement
>          Components: BeanUtils2
>            Reporter: Andre Diermann
>         Attachments: Commons-Sandbox-463.patch
>
>
> In [1] Benedikt Ritter mentioned the lag of BU1's property path for BU2.
> The attached patch contains an implementation of a PropertyInterpreter - following the
GOF Interpreter Pattern - which is able to interpret simple/index/mapped/nested properties
and any combination of it. The result is a BeanAccessor. The idea is to use the PropertyInterpreter
inside of a BeanAccessor implementation.
> The patch also contains a corresponding test case.
> Example:
> on( anyBean ).set( "contact[15].address(home).street" ).with( "Example Street 1000" );
> [1] http://markmail.org/message/pv2qpr7em4ftnulj



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message