commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Olofsson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (IO-279) Tailer erroneously considers file as new
Date Wed, 05 Mar 2014 10:47:43 GMT

    [ https://issues.apache.org/jira/browse/IO-279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13920732#comment-13920732
] 

Robert Olofsson commented on IO-279:
------------------------------------

I stumbled across this issue while tailing a file on a remote server via Samba.

The clock on the server was running a few seconds ahead of my local machine which caused the
file to be seen as newer even though it wasn't.

I solved this by simply replacing the line:

last = System.currentTimeMillis();

With:

last = file.lastModified();

That way it doesn't matter if the clocks are not in perfect sync.

> Tailer erroneously considers file as new
> ----------------------------------------
>
>                 Key: IO-279
>                 URL: https://issues.apache.org/jira/browse/IO-279
>             Project: Commons IO
>          Issue Type: Bug
>    Affects Versions: 2.0.1, 2.4
>            Reporter: Sergio Bossa
>         Attachments: IO-279.patch, disable_resetting.patch, fix-tailer.patch, modify-test-fixed.patch,
modify-test.patch
>
>
> Tailer sometimes erroneously considers the tailed file as new, forcing a repositioning
at the start of the file: I'm still unable to reproduce this in a test case, because it only
happens to me with huge log files during Apache Tomcat startup.
> This is the piece of code causing the problem:
> {code}
> // See if the file needs to be read again
> if (length > position) {
>     // The file has more content than it did last time
>     last = System.currentTimeMillis();
>     position = readLines(reader);
> } else if (FileUtils.isFileNewer(file, last)) {
>     /* This can happen if the file is truncated or overwritten
>         * with the exact same length of information. In cases like
>         * this, the file position needs to be reset
>         */
>     position = 0;
>     reader.seek(position); // cannot be null here
>     // Now we can read new lines
>     last = System.currentTimeMillis();
>     position = readLines(reader);
> }
> {code}
> What probably happens is that the new file content is about to be written on disk, the
date is already updated but content is still not flushed, so actual length is untouched and
there you go.
> In other words, I think there should be some better method to verify the condition above,
rather than relying only on dates: keeping and comparing the hash code of the latest line
may be a solution, but may hurt performances ... other ideas?



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message