Return-Path: X-Original-To: apmail-commons-issues-archive@minotaur.apache.org Delivered-To: apmail-commons-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 1CA0211907 for ; Thu, 20 Feb 2014 15:57:29 +0000 (UTC) Received: (qmail 89701 invoked by uid 500); 20 Feb 2014 15:57:20 -0000 Delivered-To: apmail-commons-issues-archive@commons.apache.org Received: (qmail 89559 invoked by uid 500); 20 Feb 2014 15:57:20 -0000 Mailing-List: contact issues-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: issues@commons.apache.org Delivered-To: mailing list issues@commons.apache.org Received: (qmail 89534 invoked by uid 99); 20 Feb 2014 15:57:19 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 20 Feb 2014 15:57:19 +0000 Date: Thu, 20 Feb 2014 15:57:19 +0000 (UTC) From: "jason mathews (JIRA)" To: issues@commons.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (NET-525) Added missing set methods on NTP class and interface MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/NET-525?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] jason mathews updated NET-525: ------------------------------ Attachment: (was: diff.patch.txt) > Added missing set methods on NTP class and interface > ---------------------------------------------------- > > Key: NET-525 > URL: https://issues.apache.org/jira/browse/NET-525 > Project: Commons Net > Issue Type: Improvement > Affects Versions: 3.3 > Reporter: jason mathews > Labels: ntp > Attachments: diff.patch.txt > > > I was the original contributor of the NTP implementation and have recently cleaned the source and submitting the relevant changes. > Here is the summary of changes: > src/main/java/org/apache/commons/net/ntp/TimeInfo.java > -Added missing equals() and hashCode() methods > -Added new method: getAddress() > src/main/java/org/apache/commons/net/ntp/NtpV3Packet.java > -Added missing methods: setPrecision(), setRootDelay(), and setRootDispersion() > src/main/java/org/apache/commons/net/ntp/NtpV3Impl.java > -Added missing equals() and hashCode() methods > -Added missing set methods: setRootDelay(), setRootDispersion(), > -Added validation check to setDatagramPacket() > Added additional tests: > -src/test/java/org/apache/commons/net/ntp/TestNtpPacket.java > -src/test/java/org/apache/commons/net/ntp/TestTimeInfo.java > See attached patch. -- This message was sent by Atlassian JIRA (v6.1.5#6160)