Return-Path: X-Original-To: apmail-commons-issues-archive@minotaur.apache.org Delivered-To: apmail-commons-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id E3CB811A55 for ; Fri, 21 Feb 2014 04:13:25 +0000 (UTC) Received: (qmail 27107 invoked by uid 500); 21 Feb 2014 04:13:23 -0000 Delivered-To: apmail-commons-issues-archive@commons.apache.org Received: (qmail 26866 invoked by uid 500); 21 Feb 2014 04:13:22 -0000 Mailing-List: contact issues-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: issues@commons.apache.org Delivered-To: mailing list issues@commons.apache.org Received: (qmail 26544 invoked by uid 99); 21 Feb 2014 04:13:20 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 21 Feb 2014 04:13:20 +0000 Date: Fri, 21 Feb 2014 04:13:20 +0000 (UTC) From: "Gary Gregory (JIRA)" To: issues@commons.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CODEC-181) Make possible to provide padding byte to BaseNCodec in constructor MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CODEC-181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13907935#comment-13907935 ] Gary Gregory commented on CODEC-181: ------------------------------------ Ivan, Thank you for your interest in Codec. Can you please provide a unit test in your patch? Thank you, Gary > Make possible to provide padding byte to BaseNCodec in constructor > ------------------------------------------------------------------ > > Key: CODEC-181 > URL: https://issues.apache.org/jira/browse/CODEC-181 > Project: Commons Codec > Issue Type: Improvement > Affects Versions: 1.9, 1.10 > Reporter: Ivan Martinez-Ortiz > Priority: Minor > Attachments: BaseNCodec_new_constructor.patch > > > Hi, > I'm developing an application that generates QRCodes, so the user does not need to type a HMAC value. QRCodes [1] supports different encoding formats, in particular the alpha numeric format is almost compatible with the Base32 (the only problematic character is the '=' character). > I created an almost exact copy of Base32 class in order to change the padding byte, however the BaseNCodec#PAD byte is final and not settable in the class constructor. > I already tested this approach and I can provide a patch to support this new feature. > [1] http://en.wikipedia.org/wiki/QR_code -- This message was sent by Atlassian JIRA (v6.1.5#6160)